cmake: Fix ggml backend dependencies and installation #11818
Merged
+9
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ggml
slaren
approved these changes
Feb 17, 2025
ggml backends link only to ggml-base and ggml links to all backends.
Set up GNUInstallDirs before setting the installation directory of ggml backends
vvuksanovic
force-pushed
the
ggml-backend-cmake-fixes
branch
from
73f78ed to
9be945f
Compare
ggerganov
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the following changes to ggml backends:
ggml,ggml-baseand backends. Linking a static build oflibllamausing cmake is currently broken because dependencies are listed in the wrong order in linker commands. Backends should only link toggml-base, andggmlshould link toggml-baseand the backends.libllama,libggmlandlibggml-baseare installed in the/lib64directory, but ggml backends are installed in/lib. That is because ggml backends have their installation directory set beforeGNUInstallDirsis included.