Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The program data is missing #41

Closed
Mattwalsh129 opened this issue May 10, 2016 · 8 comments
Closed

The program data is missing #41

Mattwalsh129 opened this issue May 10, 2016 · 8 comments
Milestone
Iteration 5

Comments

@Mattwalsh129
Copy link
Collaborator

So if you click on a school that is colored none of the info is there. It only shows up before you click 'add program'
@ghing
Copy link
Owner

ghing commented May 10, 2016

I'm not able to replicate this. Seems to be working for me:

screen shot 2016-05-10 at 3 11 07 pm

Is there a particular school that you can tell me to try to replicate this?

@Mattwalsh129
Copy link
Collaborator Author

Once you click the 'add program' button it is gone. and if you were to
click around it continues as such:
[image: Inline image 1]

On Tue, May 10, 2016 at 3:12 PM, Geoffrey Hing [email protected]
wrote:

I'm not able to replicate this. Seems to be working for me:

[image: screen shot 2016-05-10 at 3 11 07 pm]
https://cloud.githubusercontent.com/assets/110420/15160899/80c99b1e-16c1-11e6-9ed7-c4ac013fc423.png

Is there a particular school that you can tell me to try to replicate this?

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#41 (comment)

Matthew Kennedy Walsh

@ghing
Copy link
Owner

ghing commented May 10, 2016

If you finish adding the program, it will once again show the list. If you click "Cancel" it will hide the add program form and show the list. Perhaps it would make sense to have it always revert to the list when you click on a new school, even if the add program list hasn't been cancelled.

@Mattwalsh129
Copy link
Collaborator Author

I think i understand what you mean and I agree that it should revert back

@Mattwalsh129
Copy link
Collaborator Author

Following up on this

@ghing ghing added this to the Iteration 5 milestone Jun 1, 2016
ghing added a commit that referenced this issue Jun 1, 2016
@ghing
Use actions to change program mode
d6fd432 
The application currently has 3 modes:

* Viewing a school detail
* Adding a school program
* Editing a school program

Try to make this state live at the top level (in SchoolStore)
and passed down as props instead of living in a downstream view.

Change the state using actions.

This seems like a more Fluxy way to do it, and is ultimately
easier for me to reason about.

All of this was changes that I noticed should be made on the way
to reseting back to showing a school detail when a new school is
selected.

Addresses #41
@ghing ghing closed this as completed in 0e76886 Jun 2, 2016
@Mattwalsh129
Copy link
Collaborator Author

I am not sure if this is working for me?
The idea would be that when I clicked on a new school it would revert back
to the original not the edit program item?

On Wed, Jun 1, 2016 at 8:59 PM, Geoffrey Hing [email protected]
wrote:

Closed #41
#41 via
0e76886
0e76886
.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#41 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ARceHPNZPHf7l0aGXq9luZcHOTAWdbuUks5qHjjzgaJpZM4IbdcC
.

Matthew Kennedy Walsh

@ghing
Copy link
Owner

ghing commented Jun 3, 2016

Haven't deployed this yet
On Jun 2, 2016 7:06 PM, "Mattwalsh129" [email protected] wrote:

I am not sure if this is working for me?
The idea would be that when I clicked on a new school it would revert back
to the original not the edit program item?

On Wed, Jun 1, 2016 at 8:59 PM, Geoffrey Hing [email protected]
wrote:

Closed #41
#41 via
0e76886
<
0e76886

.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<
#41 (comment)
,
or mute the thread
<
https://github.com/notifications/unsubscribe/ARceHPNZPHf7l0aGXq9luZcHOTAWdbuUks5qHjjzgaJpZM4IbdcC

.

Matthew Kennedy Walsh

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
#41 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAGvVAz6p3kld7LMyTsEb0mScJ4A2ZzHks5qH3AKgaJpZM4IbdcC
.

@ghing
Copy link
Owner

ghing commented Jun 3, 2016

Deployed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Iteration 5
Development

No branches or pull requests
2 participants
@ghing @Mattwalsh129