GITC-389 Remove duplicates from explore page #9695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksolo
requested review from
frankchen07,
PixelantDesign and
thelostone-mc
as code owners
jeremyschuurmans
approved these changes
Nov 18, 2021
gdixon
suggested changes
Nov 19, 2021
app/assets/v2/js/grants/index.js
Outdated
| @@ -320,8 +320,13 @@ if (document.getElementById('grants-showcase')) { | |||
| if (!append_mode) { | |||
| vm.grants = []; | |||
| } | |||
|
|
|||
| const previouslyLoadedIds = vm.grants.map(grant => grant.id); | |||
There was a problem hiding this comment.
Consider: moving this to the vue model to avoid creating the mapping every time we call fetchGrants()
app/assets/v2/js/grants/index.js
Outdated
| getGrants.grants.forEach(function(item) { | ||
| vm.grants.push(item); | ||
| if (!previouslyLoadedIds.includes(item.id)) { |
There was a problem hiding this comment.
If previouslyLoadedIds was stored as an object against the viewModel we could make this check O(1) instead of O(n) and avoid the need to map vm.grants into previouslyLoadedIds each call...
Suggested change
| if (!previouslyLoadedIds.includes(item.id)) { | |
| if (!vm.previouslyLoadedIds[item.id]) { | |
| vm.previouslyLoadedIds[item.id] = item; |
added 2 commits
November 21, 2021 17:33
ksolo
force-pushed
the
gitc-389/prevent-duplicate-grant-results
branch
from
82d7c49 to
9b69c1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a quick fix for resolving the bug in GITC-389. When in append mode (the mode triggered from scrolling), before adding new grants received from the server, it will check to see if it already exists. A more robust fix can be included in the server, that will be added as a new ticket.
Refers/Fixes
GITC-389
Testing
Tested locally