Do some just+pre-commit tweaking #2776
Conversation
* pre-commit: move the linting check ahead of the compiling one, as a typescript lint can change the compilaed javascript, so you can end up in a situation where the pre-commit check fails twice in a row * just: add linting and make the default to run all
There was a problem hiding this comment.
PR Overview
This PR refactors the pre-commit hook ordering to run TypeScript linting before compiling, helping to reduce redundant error reporting. Additionally, the README.md file has been entirely removed.
- Reorders hooks in .pre-commit-config.yaml so that the lint-ts hook runs before compile-ts.
- Removes the README.md file, which may impact project documentation.
Reviewed Changes
| File | Description |
|---|---|
| .pre-commit-config.yaml | Added lint-ts hook before compile-ts to avoid double failure on lint. |
| README.md | Removed README.md, potentially impacting existing documentation. |
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
README.md:1
- The removal of the README.md file may result in the loss of important project documentation. If this change is intentional, please ensure that the documentation is provided elsewhere and all related references are updated.
Entire README content removed.
Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more
| @@ -1,3 +1,10 @@ | |||
| # Perform all working copy cleanup operations | |||
| all: lint sync | |||
There was a problem hiding this comment.
Bikeshed: does all usually imply that it includes all the recipes (in this case also build)?
There was a problem hiding this comment.
👋 sync includes both build and update-pr-checks, so transitively all includes indeed all.
There was a problem hiding this comment.
Oh yes I see! Missed that 🤦
Merge / deployment checklist