Test: Add support for RelatedLocation tag and use in a JS query #18810
+85
−59
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for marking related locations with
// $ RelatedLocation
inline comments. They are only expected if at least one such comment exists in the test; and if so then all related locations must be annotated.Some queries use a primary alert location such that a large number of alerts get consolidated into a single alert. For such queries simply putting
$ Alert
on the consolidated alert line isn't a good choice. For path problems this is rarely a problem as we haveSource
andSink
tags, but for non-path problems it can be an issue.This PR migrates the JS
MissingCsrfMiddleware
test to inline expectations so the behaviour is exercised. This query flags the cookie-parsing middleware function, as opposed to the vulnerable route handler function, because there can be a huge number of vulnerable route handlers that are all far away from the root cause of the vulnerability.