Rust: strengthen linting script #18822
Open
+27
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `bazel run //rust/ast-generator:inject-sources` could fail on macOS if a non-coreutils `cp` was used * that is now also run by `lint.py` to ensure the sources cargo needs are present
There was a problem hiding this comment.
PR Overview
This PR strengthens the linting script to ensure that required binaries are present and the necessary source injections are performed for Rust projects.
- Refactors binary detection using a helper function.
- Introduces a uniform run function to execute commands and log their calls.
- Integrates bazel source injection alongside cargo formatting and clippy corrections.
Reviewed Changes
| File | Description |
|---|---|
| rust/lint.py | Improved binary detection, command execution, and source injection. |
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bazel run //rust/ast-generator:inject-sourcescould fail on macOS if a non-coreutilscpwas usedlint.pyto ensure the sources cargo needs are present