-
Notifications
You must be signed in to change notification settings - Fork 61.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update linking-a-pull-request-to-an-issue.md #198
Conversation
Fixes part of github#165 (last suggestion made by the author)
Thanks @casals! I'll send both of these PRs to the @github/docs-content-core team to review 😸 |
Thanks for this PR! I see you made this same change (along with others) in #199, so I'll close this PR in favor of that one 💖 ✨ and we'll get it reviewed and merged 🔜 |
Hello @myarb - actually the original issue suggested two different alterations in two different documents, so I ended up opening a PR for each of them. This PR refers to complementing the subsection description with "or in a commit message" - which results in a more accurate description of the linking feature. Thanks! |
👋🏼 @casals I'm sorry if I misunderstood. If you look at the edited file in this PR (here) and the edited file in the other PR (#199, here), the paragraph under the header |
Hey @myarb - you're right - I'm terribly sorry. I had another pair of PRs related to the same issue and I thought this was the right pair. I have absolutely no idea why I opened 2 PRs for the same file 😅 Sorry for the confusion! |
* add webhook * use descriptive title, use full url instead of secret
Why:
Fixes part of #165 (last suggestion made by the author)
What's being changed:
Issue #165 requires two different fixes. This is the first one, related to changing the document "Linking a pull request to an issue". As suggested by the linked issue's author, I changed the introductory sentence at the beginning of the referenced section to "You can link a pull request to an issue by using a supported keyword in the pull request's description or in a commit message."
Check off the following: