Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update linking-a-pull-request-to-an-issue.md #198

Closed
wants to merge 2 commits into from

Conversation

casals
Copy link
Contributor

@casals casals commented Oct 7, 2020

Why:

Fixes part of #165 (last suggestion made by the author)

What's being changed:

Issue #165 requires two different fixes. This is the first one, related to changing the document "Linking a pull request to an issue". As suggested by the linked issue's author, I changed the introductory sentence at the beginning of the referenced section to "You can link a pull request to an issue by using a supported keyword in the pull request's description or in a commit message."

Check off the following:

Fixes part of github#165 (last suggestion made by the author)
@janiceilene
Copy link
Contributor

Thanks @casals! I'll send both of these PRs to the @github/docs-content-core team to review 😸

@janiceilene janiceilene added content This issue or pull request belongs to the Docs Content team core labels Oct 7, 2020
@myarb
Copy link
Contributor

myarb commented Oct 13, 2020

Thanks for this PR! I see you made this same change (along with others) in #199, so I'll close this PR in favor of that one 💖 ✨ and we'll get it reviewed and merged 🔜

@myarb myarb closed this Oct 13, 2020
@casals
Copy link
Contributor Author

casals commented Oct 13, 2020

Hello @myarb - actually the original issue suggested two different alterations in two different documents, so I ended up opening a PR for each of them. This PR refers to complementing the subsection description with "or in a commit message" - which results in a more accurate description of the linking feature. Thanks!

@myarb
Copy link
Contributor

myarb commented Oct 14, 2020

👋🏼 @casals I'm sorry if I misunderstood. If you look at the edited file in this PR (here) and the edited file in the other PR (#199, here), the paragraph under the header Linking a pull request to an issue using a keyword is edited in both with "or in a commit message." I believe #199 captures both alterations, but please let me know if I misunderstood!

@casals
Copy link
Contributor Author

casals commented Oct 14, 2020

Hey @myarb - you're right - I'm terribly sorry. I had another pair of PRs related to the same issue and I thought this was the right pair. I have absolutely no idea why I opened 2 PRs for the same file 😅 Sorry for the confusion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants