Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed small typo in adopting GHAS at scale #22637

Merged
merged 4 commits into from
Dec 13, 2022
Merged

fixed small typo in adopting GHAS at scale #22637

merged 4 commits into from
Dec 13, 2022

Conversation

CallMeGreg
Copy link
Contributor

@CallMeGreg CallMeGreg commented Dec 13, 2022 •
edited
Loading

Why:

No issue created, just a small grammar typo.

What's being changed (if available, include any code snippets, screenshots, or gifs):

small grammar typo

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

@welcome
Copy link

welcome bot commented Dec 13, 2022

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Dec 13, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 13, 2022 •
edited
Loading

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
code-security/adopting-github-advanced-security-at-scale/phase-1-align-on-your-rollout-strategy-and-goals.md ghec
ghes@ 3.7 3.6 3.5 3.4 3.3
ghae
 ghec
ghes@ 3.7 3.6 3.5 3.4 3.3
ghae

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@CallMeGreg CallMeGreg changed the title fixed small typo in phase 1 description fixed small typo in adopting GHAS at scale Dec 13, 2022
@CallMeGreg CallMeGreg changed the title fixed small typo in adopting GHAS at scale fixed small typos in adopting GHAS at scale Dec 13, 2022
@CallMeGreg CallMeGreg changed the title fixed small typos in adopting GHAS at scale fixed small typo in adopting GHAS at scale Dec 13, 2022
@cmwilson21
Copy link
Contributor

👋 @CallMeGreg Thanks so much for opening a PR! I'll get this triaged for review ⚡

@cmwilson21 cmwilson21 added code security Content related to code security content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Dec 13, 2022
sophietheking
sophietheking approved these changes Dec 13, 2022
View reviewed changes
Copy link
Contributor

@sophietheking sophietheking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot, thanks for fixing this! Marking this as approved and merging it. ⚡

@sophietheking sophietheking removed the waiting for review Issue/PR is waiting for a writer's review label Dec 13, 2022
@sophietheking sophietheking merged commit 6a7c13c into github:main Dec 13, 2022
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sophietheking sophietheking sophietheking approved these changes

Assignees
No one assigned
Labels
code security Content related to code security content This issue or pull request belongs to the Docs Content team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CallMeGreg @cmwilson21 @sophietheking