gl-surface3d > Implement surface opacityscale & correct display of transparent surfaces #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archmoj
commented
Jan 10, 2020
| @@ -200,6 +205,22 @@ proto.setPickBase = function (id) { | |||
| this.pickId = id | |||
| } | |||
|
|
|||
| function getOpacityFromScale(ratio, opacityscale) { // copied form gl-mesh3d | |||
There was a problem hiding this comment.
It would be nice to start a helper module in gl-vis to reuse logic like this in both gl-mesh3d and gl-surface3d.
archmoj
commented
Jan 10, 2020
| @@ -67,13 +67,14 @@ function SurfacePickResult (position, index, uv, level, dataCoordinate) { | |||
|
|
|||
| var N_COLORS = 256 | |||
|
|
|||
| function genColormap (name) { | |||
| function genColormap (name, opacityscale) { | |||
There was a problem hiding this comment.
It would be nice to start a helper module in gl-vis to reuse logic like this in both gl-mesh3d and gl-surface3d.
|
@archmoj where exactly is the "correct display of transparent surfaces" part of this PR? Splitting this up into two commits would have been nice. |
I did try to split that into two commits. But strangely it didn't work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please refer to plotly/plotly.js#4480 for more info.
@etpinard
@alexcjohnson