Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Go to type definition" capability #4246

Merged
merged 5 commits into from
Feb 17, 2025
Merged

Conversation

giacomocavalieri
Copy link
Member

This PR closes #4194

Instead of using a `&str` we instead use an `EcoString` that removes the
lifetime annotation making the code easier
@giacomocavalieri giacomocavalieri changed the title Add "Go to type definition capability" Add "Go to type definition" capability Feb 14, 2025
@giacomocavalieri giacomocavalieri marked this pull request as draft February 14, 2025 19:00
@giacomocavalieri giacomocavalieri marked this pull request as ready for review February 14, 2025 19:21
Copy link
Member

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful!! Could you update the changelog please 🙏

@giacomocavalieri
Copy link
Member Author

Oops forgot about the changelog, done it!

Copy link
Member

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@lpil lpil merged commit dcf6bf9 into gleam-lang:main Feb 17, 2025
12 checks passed
@giacomocavalieri giacomocavalieri deleted the fix-4194 branch February 17, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LSP: Goto Type definition
2 participants