Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cot edit-properties interactive is broken in v1.2.2 #29

Closed
glennmatthews opened this issue Mar 6, 2015 · 1 comment
Closed

cot edit-properties interactive is broken in v1.2.2 #29

glennmatthews opened this issue Mar 6, 2015 · 1 comment
Assignees
Labels

Comments

@glennmatthews
Copy link
Owner

In v1.2.2 the interactive edit-properties mode is no longer entered if no properties are given on the command line:

> cot edit-properties -o foo.ovf COT/tests/input.ovf 
    INFO: Loading 'COT/tests/input.ovf' as OVF
    INFO: OVF version is 1.x
    INFO: OVF product class None --> platform GenericPlatform
Overwrite existing file foo.ovf? [y] y
    INFO: Writing out to file foo.ovf
    INFO: Copying input.vmdk to /Users/glmatthe/Documents/OVF_Tools/cot-public/cot
    INFO: Copying input.iso to /Users/glmatthe/Documents/OVF_Tools/cot-public/cot

In v1.2.1 the functionality still works:

> cot edit-properties -o foo.ovf COT/tests/input.ovf 
    INFO: Loading 'COT/tests/input.ovf' as OVF
    INFO: OVF version is 1.x
    INFO: OVF product class None --> platform GenericPlatform
Overwrite existing file foo.ovf? [y] y

Please choose a property to edit:
   1) "Login Username"                         (login-username)
   2) "Login Password"                         (login-password)
   3) "Management IPv4 Address/Mask"           (mgmt-ipv4-addr)
   4) "Management IPv4 Default Gateway"        (mgmt-ipv4-gateway)
   5) "Router Name"                            (hostname)
   6) "Enable SSH Login"                       (enable-ssh-server)
   7) "Enable HTTP Server"                     (enable-http-server)
   8) "Enable HTTPS Server"                    (enable-https-server)
   9) "Enable Password"                        (privilege-password)
  10) "Domain Name"                            (domain-name)
@glennmatthews glennmatthews self-assigned this Mar 6, 2015
@glennmatthews
Copy link
Owner Author

Regression introduced by 9db1bdc

glennmatthews added a commit that referenced this issue Mar 6, 2015
Fix issue #29. Interactive 'edit-properties' is now better than ever before.
Various refactoring of OVF class to be more Pythonic.
Other miscellaneous bug fixes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant