-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App example using webpack: Make it more interactive #489
Comments
@sotojuan this is looking great. Although, note the following. When we change the formatter value only (e.g., changing the number in the first example), we use the same formatter to format various values, which is great. When we change the formatter options (e.g., changing the currency code, date pattern, or relative time unit), we are actually using different formatters, not reusing a formatter, which has its consequences: while it works just fine in development mode, where you can generate any formatter, it won't work in production mode, where it's expected that the formatter be compiled and available. To make long story short, make dynamic the formatter values only, i.e.:
Does it sound good? Thanks so far! PS: Note you can make the relative time or patterns dynamic, but that would require a code analogous to #481 (comment). |
Gotcha, I made the following changes:
Let me know how this looks! I just need to handle bad inputs, add some comments, and look at the style guide again. |
@sotojuan sorry for my delayed answer, it looks better. From the picture above, I read |
Yep, thanks for catching that. I'm a bit busy now but later I will clean it up and follow the style guide and submit a PR. Thanks! |
Excellent. Looking forward to it and thanks. |
Added uniq to with_translations to prevent duplicates when fallbacks are defined
Allow user to change number, currency, and the number of remaining tasks for the pluralization example.
This issue has been motivated by @sompylasar comment:
The text was updated successfully, but these errors were encountered: