Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pip installation instructions #28

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

astrofrog
Copy link
Member

The extras mentioned did not all work

Copy link
Contributor

@dhomeier dhomeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Covers largely my thoughts on qt6 install options.

Comment on lines +19 to +20
The ``[qt]`` ensures PyQt5 gets installed, but you can also install PyQt6 or
PySide yourself and miss out the ``[qt]``.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The ``[qt]`` ensures PyQt5 gets installed, but you can also install PyQt6 or
PySide yourself and miss out the ``[qt]``.
pip install PyQt6 glue-qt # Qt6-based front-end
The ``[qt]`` ensures PyQt5 gets installed and set as the front-end,
but you can also use **instead** an already installed PyQt6 or PySide
front-end, or install it along the glue libraries as above (omitting the ``[qt]``).

Perhaps clarifying the different options a bit better here? Or maybe we should link/refer to the qtpy documentation how the default front-end is picked or prescribed setting QT_API?

dev: git+https://github.com/astropy/astropy
dev: numpy>=0.0.dev0
dev: scipy>=0.0.dev0
dev: astropy>=0.0.dev0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added these to #26 as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants