Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug/PM-618: Display WETH for Dashboard/Header and fix profits display #334

Merged
merged 1 commit into from
May 16, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions config/environments/staging/interface.config.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,11 @@
"default": "METAMASK",
"requireTOSAccept": true
},
"collateralToken": {
"address": "0xd19bce9f7693598a9fa1f94c548b20887a33f141",
"symbol": "WETH",
"icon": "/assets/img/icons/icon_etherTokens.svg"
},
"footer": {
"enabled": true,
"content": {
Expand Down
6 changes: 4 additions & 2 deletions src/components/Dashboard/Metrics/Layout.js
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,12 @@ const Metrics = ({
}) => (
<Block className={cx('ol-db-container')} margin="md">
<Metric img={tokenIcon} explanation={`${tokenSymbol} TOKENS`}>
<DecimalValue value={tokens} className={cx('ol-db-title')} />
<span className={cx('ol-db-title')}>
<DecimalValue value={tokens} /> {tokenSymbol}
</span>
</Metric>
<Metric img={outstandingPredictions} width={45} height={45} explanation="PREDICTED PROFITS">
<Block className={cx('ol-db-title')}>{predictedProfit}</Block>
<Block className={cx('ol-db-title')}>{predictedProfit} {tokenSymbol}</Block>
</Metric>
{tournamentEnabled && (
<React.Fragment>
Expand Down
3 changes: 2 additions & 1 deletion src/components/Dashboard/Metrics/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ class Metrics extends React.PureComponent {
const {
predictedProfit, tokens, tokenSymbol, tokenIcon, rank, badge,
} = this.props

return (
<Layout
tokens={tokens}
Expand All @@ -45,4 +46,4 @@ class Metrics extends React.PureComponent {
}
}

export default connect(selector)(Metrics)
export default Metrics
1 change: 1 addition & 0 deletions src/components/Dashboard/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -329,6 +329,7 @@ class Dashboard extends Component {
const {
hasWallet, collateralToken, accountPredictiveAssets,
} = this.props

let metricsSection = <div />
let tradesHoldingsSection = <div className="dashboardWidgets dashboardWidgets--financial" />
const predictedProfitFormatted = Decimal(accountPredictiveAssets).toDP(4, 1).toString()
Expand Down
1 change: 0 additions & 1 deletion src/containers/DashboardPage/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ const mapStateToProps = (state) => {
const gnosisInitialized = isGnosisInitialized(state)
const hasWallet = checkWalletConnection(state)
const collateralToken = getCollateralTokenInfo(state)

return {
hasWallet,
defaultAccount,
Expand Down
2 changes: 1 addition & 1 deletion src/containers/HeaderContainer/store/actions.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import { getCollateralToken } from 'utils/features'
* Requests the configured tournaments collateralToken balance. If none is set, does nothing
* @param {function} dispatch
*/
const requestTournamentTokenBalance = dispatch => (account) => {
const requestTournamentTokenBalance = account => (dispatch) => {
const tournamentToken = getCollateralToken()

if (!tournamentToken) {
Expand Down
4 changes: 2 additions & 2 deletions src/selectors/blockchain.js
Original file line number Diff line number Diff line change
Expand Up @@ -39,14 +39,14 @@ export const getCollateralTokenInfo = (state) => {
if (!collateralToken) {
return {
symbol: 'ETH',
amount: weiToEth(getCurrentBalance(state)),
amount: getCurrentBalance(state),
address: undefined,
icon: ETH_TOKEN_ICON,
}
}

return {
symbol: getTokenSymbol(state, collateralToken.address),
symbol: collateralToken.symbol || getTokenSymbol(state, collateralToken.address),
amount: weiToEth(getTokenAmount(state, collateralToken.address)),
address: collateralToken.address,
icon: collateralToken.icon,
Expand Down