Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checker: Ensure that the processor is reset before checking each domain. #523

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

s-l-teichmann
Copy link
Contributor

@s-l-teichmann s-l-teichmann commented Jan 8, 2024

In issue #522 there are signs that the checker get mixed up when checking multiple domains.

One possible reason could be the not proper reset of the processor before checking
a particular. This PR guarantees that the reset is done before the check.

Maybe fixes #522

Copy link
Contributor

@ThomasJunk ThomasJunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@JanHoefelmeyer JanHoefelmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell, LGTM && works

@s-l-teichmann s-l-teichmann merged commit 9a1c66e into main Jan 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSAF checker: mixing domains, failing validations
3 participants