Skip to content

Commit

Permalink
cmd/release: revert "notify explorer of PATH update after install on …
Browse files Browse the repository at this point in the history
…Win"

This reverts commit 924bb6b.
https://golang.org/cl/36324

When running the release builds, we get this error:

   C:\workdir\windows\installer.wxs(155) : error LGHT0094 : Unresolved
reference to symbol 'CustomAction:WixBroadcastEnvironmentChange' in
section 'Product:*'.

The wix documentation indicates we need to enable it:
http://wixtoolset.org/documentation/manual/v3/customactions/wixsettingchange.html

In any case, reverting this change for the 1.8 release.

Updates golang/go#18680.

Change-Id: I86e8d82dc57e585c11846edf589c4bab84a60308
Reviewed-on: https://go-review.googlesource.com/37135
Reviewed-by: Jeff Johnson <[email protected]>
Reviewed-by: Chris Broadfoot <[email protected]>
  • Loading branch information
broady committed Feb 16, 2017
1 parent 0c329e9 commit 4932e8b
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions cmd/release/releaselet.go
Original file line number Diff line number Diff line change
Expand Up @@ -681,9 +681,6 @@ var windowsData = map[string]string{
<Custom Action="SetApplicationRootDirectory" Before="InstallFinalize" />
</InstallExecuteSequence>
<!-- Notify top level applications of the new PATH variable (golang.org/issue/18680) -->
<CustomActionRef Id="WixBroadcastEnvironmentChange" />
<!-- Include the user interface -->
<WixVariable Id="WixUILicenseRtf" Value="LICENSE.rtf" />
<WixVariable Id="WixUIBannerBmp" Value="images\Banner.jpg" />
Expand Down

0 comments on commit 4932e8b

Please sign in to comment.