x/website: fails to deploy with Go 1.18 #51686
Comments
heschi
added
the
Soon
|
This is related to golang.org/x/website/cmd/golangorg being currently deployed to App Engine with I'll send a CL to x/website to add the latest spec documents as a temporary workaround while this issue is worked on. |
|
Change https://go.dev/cl/393115 mentions this issue: |
The canonical location for these documents is in the main Go repository in the doc directory. Due to go.dev/issue/51686, the website is using Go content from release-branch.go1.17 rather than release-branch.go1.18. Temporarily add a copy of the spec docs to x/website so it's possible to view them at go.dev (in addition to tip.golang.org) while that issue is being resolved. For golang/go#51686. Change-Id: Ia6640d6c32af631f562db1294d191f461373b9ee Reviewed-on: https://go-review.googlesource.com/c/website/+/393115 Run-TryBot: Dmitri Shuralyov <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Heschi Kreinick <[email protected]> Trust: Dmitri Shuralyov <[email protected]>
|
Well that's embarrassing. I will vendor in a copy of go/build I guess. |
|
So was tip just broken for a long time and we didn't notice? |
|
@rsc I expect so, at least since those old-style // +build comments were removed on tip, thought can't back that up without looking closer. I'm not sure if there's more work involved in updating x/website's documentation rendering to handle generics. I left #48264 (comment) but that issue was about x/pkgsite. |
|
#44356 (comment) suggests the https://tip.golang.org/pkg/net/http/?m=old problem existed since Oct 28, 2021. |
|
Oh, and the tip redirect meant that most people didn't notice. |
|
Change https://go.dev/cl/393194 mentions this issue: |
dmitshur
added
the
NeedsFix
…port/go/*
The immediate need was go/build, because the Go 1.16 go/build rejects
code that has //go:build without // +build, as Go 1.18 code now does.
But displaying code using generics would also have failed, for inability
to parse that code. Add the full go/ast, go/doc, go/format, go/parser,
go/printer, go/scanner, and go/token to fix those failures, which
would become more frequent as generics are used more inside the
standard library.
The code is all from the go1.18 tag of the Go repo, post-processed to
rewrite imports and apply gofmt -w -r 'any -> interface{}' to keep it
building with the other backports and with Go 1.16 syntax.
For golang/go#51686.
Change-Id: I1e14f4634d8bc09bdaa04c014eadb1be97ea5047
Reviewed-on: https://go-review.googlesource.com/c/website/+/393194
Trust: Russ Cox <[email protected]>
Run-TryBot: Russ Cox <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
|
The web site is serving the Go 1.18 tree now. Leaving open because I think Dmitri wanted to roll back CL 393115. |
|
I'll do that, making sure the spec isn't changing as a result (it shouldn't). Removing Soon since this is mostly mitigated. Thank you Russ. |
dmitshur
removed
the
Soon
|
Change https://go.dev/cl/393355 mentions this issue: |
|
Change https://go.dev/cl/414515 mentions this issue: |
It was #51868 not #51686. For #53310. Change-Id: I2cf28ca4de65e7030fdbd05e7f32fe42c8f3ca0a Reviewed-on: https://go-review.googlesource.com/c/go/+/414515 Reviewed-by: Ian Lance Taylor <[email protected]> Reviewed-by: Than McIntosh <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Run-TryBot: Russ Cox <[email protected]> Reviewed-by: Cherry Mui <[email protected]>
It was golang#51868 not golang#51686. For golang#53310. Change-Id: I2cf28ca4de65e7030fdbd05e7f32fe42c8f3ca0a Reviewed-on: https://go-review.googlesource.com/c/go/+/414515 Reviewed-by: Ian Lance Taylor <[email protected]> Reviewed-by: Than McIntosh <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Run-TryBot: Russ Cox <[email protected]> Reviewed-by: Cherry Mui <[email protected]>
The canonical location for these documents is in the main Go repository in the doc directory. Due to go.dev/issue/51686, the website is using Go content from release-branch.go1.17 rather than release-branch.go1.18. Temporarily add a copy of the spec docs to x/website so it's possible to view them at go.dev (in addition to tip.golang.org) while that issue is being resolved. For golang/go#51686. Change-Id: Ia6640d6c32af631f562db1294d191f461373b9ee Reviewed-on: https://go-review.googlesource.com/c/website/+/393115 Run-TryBot: Dmitri Shuralyov <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Heschi Kreinick <[email protected]> Trust: Dmitri Shuralyov <[email protected]>
…port/go/*
The immediate need was go/build, because the Go 1.16 go/build rejects
code that has //go:build without // +build, as Go 1.18 code now does.
But displaying code using generics would also have failed, for inability
to parse that code. Add the full go/ast, go/doc, go/format, go/parser,
go/printer, go/scanner, and go/token to fix those failures, which
would become more frequent as generics are used more inside the
standard library.
The code is all from the go1.18 tag of the Go repo, post-processed to
rewrite imports and apply gofmt -w -r 'any -> interface{}' to keep it
building with the other backports and with Go 1.16 syntax.
For golang/go#51686.
Change-Id: I1e14f4634d8bc09bdaa04c014eadb1be97ea5047
Reviewed-on: https://go-review.googlesource.com/c/website/+/393194
Trust: Russ Cox <[email protected]>
Run-TryBot: Russ Cox <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
…ents" Revert commit 2e3ad7d979299962a9e843e8eb77f28f337c37cb (CL 393115). By now, the website is using Go content from release-branch.go1.18, so this temporary mitigation is no longer needed. Fixes golang/go#51686. Change-Id: I47e3962cdffd88c708e1c150d9cf4bdcac217b24 Reviewed-on: https://go-review.googlesource.com/c/website/+/393355 Run-TryBot: Dmitri Shuralyov <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Trust: Dmitri Shuralyov <[email protected]> Reviewed-by: Heschi Kreinick <[email protected]>
golang.org is failing to deploy due to failing tests:
https://tip.golang.org/pkg/net/http/?m=old shows:
For now we're going to keep the website on 1.17.
cc @rsc @golang/release
The text was updated successfully, but these errors were encountered: