Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added korean translation #195

Merged

Conversation

hinco114
Copy link
Contributor

@hinco114 hinco114 commented Jun 9, 2018

  1. Merged master branch to korean-translation.
  2. Existing README.korean.md file texts were chinese, I copied README.md file to README.korean.md.
  3. Only translated some parts of main page.

duartemendes and others added 26 commits May 6, 2018 17:46
Make the markdown in README.md consistent:
1. Remove multiple spaces in between words
2. Remove periods at the end of paragraphs
3. Remove extra line breaks
4. Add line breaks where missing
5. Ensure three `<br>`s at the end of level 1 headings
6. Format HTML
…iods

Fix spaces, periods and line breaks
1. Fix grammar and a typo in section '5.10. Measure and guard the memory usage'
2. Add a link to Walmart Node.js Memory Leak from Joyent blog for context
* Change total from 16 to 17 for '5.Going To Production Practices' in ToC.
Update total for '5. Going To Production Practices' in ToC
1. Update top badges with best practices item count, last update date and Node.js version
2. Award flowers to merged PR contributors
…nance

Service maintenance chores for April
goldbergyoni#187: 5.7. maintenance endpoint is dangerous when it becomes a target…
- The language of README.korean.md was Chinese, Replaced README.korean.md contents with latest version of README.md
- Only translated title, and some contents of main page
@goldbergyoni
Copy link
Owner

@hinco114 Cool, we have the first part of it. You plan to handle the rest alone, need some help, share with me how do you see the process moving on, I might have some resources that can help

@goldbergyoni goldbergyoni merged commit 57db262 into goldbergyoni:korean-translation Jun 15, 2018
elite0226 pushed a commit to elite0226/nodebestpractices that referenced this pull request Oct 31, 2022
MatanYadaev pushed a commit to MatanYadaev/nodebestpractices that referenced this pull request Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants