gltfio: add support for KHR_materials_variants #5361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested the Java API by hacking ModelViewer. Tested the JavaScript API by adding to filament-viewer-test.
romainguy
approved these changes
Mar 24, 2022
| @@ -83,7 +83,8 @@ <h3>Skybox, fixed size</h3> | |||
| <h3>No skybox, no IBL, fixed size, round border</h3> | |||
| <p> | |||
| <filament-viewer | |||
| src="https://prideout.net/models/dino/trex.gltf" | |||
| src="https://prideout.net/models/MaterialsVariantsShoe.glb" | |||
There was a problem hiding this comment.
We should prob not rely on your domain name btw.
There was a problem hiding this comment.
Maybe we should make an assets repo at some point. I tried replacing these with blob URL's from the Khronos repo and ran into fun CORS errors:
Access to fetch at 'https://github.com/KhronosGroup/glTF-Sample-Models/raw/master/2.0/MaterialsVariantsShoe/glTF-Binary/MaterialsVariantsShoe.glb' from origin 'http://127.0.0.1:8080' has been blocked by CORS policy: The 'Access-Control-Allow-Origin' header has a value 'https://render.githubusercontent.com' that is not equal to the supplied origin. Have the server send the header with a valid value, or, if an opaque response serves your needs, set the request's mode to 'no-cors' to fetch the resource with CORS disabled.
pixelflinger
approved these changes
Mar 24, 2022
|
In a subsequent PR, I would like to add an applyMaterialVariant method to FilamentInstance. |
Yes it might make sense to expose the MaterialInstance objects associated with a given variant, I might do that in my follow up PR. (Makes less sense to expose Material, those are owned by the MaterialProvider and are widely shared.) |
prideout
force-pushed
the
pr/variants
branch
2 times, most recently
from
61cabf0 to
e0a1e27
Compare
Tested by hacking ModelViewer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested the Java API by hacking ModelViewer.
Tested the JavaScript API by adding to filament-viewer-test.