Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake FindFlatBuffers.cmake vs FlatbuffersConfig.cmake #7323

Closed
clanghans opened this issue May 24, 2022 · 1 comment
Closed

CMake FindFlatBuffers.cmake vs FlatbuffersConfig.cmake #7323

clanghans opened this issue May 24, 2022 · 1 comment

Comments

@clanghans
Copy link
Contributor

Hi all,

I have noticed an inconsistency in the CMake handling around the find_package mechanism.

If I use the FindFlatBuffers.cmake file I need to include it like this:
find_package(FlatBuffers) and if I want to use the config mode of the find_package mechanism I need to do
find_package(Flatbuffers CONFIG).

According to the CMake find_package documentation the typical lookup is for <lowercasePackageName>-config.cmake or <PackageName>Config.cmake

Noticed the same with the generated FlatbuffersTargets.cmake.

I have already made the changes and would be happy to provide a PR if we agree that this needs to be changed.
@dbaileychess
Copy link
Collaborator

Sure, PRs are welcome

@clanghans clanghans mentioned this issue Jul 12, 2022
Merged
dbaileychess pushed a commit that referenced this issue Aug 6, 2022
@clanghans
(#7323) Rename CMake files according to project name (#7378)
aa395e5 
* CMake find_package fixes (#7323)

Rename FlatbuffersConfigVersion.cmake to match CMake project name

* CMake find_package fixes (#7323)

Rename FlatBuffersTargets to match CMake project name
sssooonnnggg pushed a commit to sssooonnnggg/flatbuffers that referenced this issue Aug 8, 2022
@clanghans @sssooonnnggg
(google#7323) Rename CMake files according to project name (google#7378)
7b038a0 
* CMake find_package fixes (google#7323)

Rename FlatbuffersConfigVersion.cmake to match CMake project name

* CMake find_package fixes (google#7323)

Rename FlatBuffersTargets to match CMake project name
This was referenced Aug 31, 2022
Closed
Merged
jochenparm pushed a commit to jochenparm/flatbuffers that referenced this issue Oct 29, 2024
@clanghans
(google#7323) Rename CMake files according to project name (google#7378)
22880dd 
* CMake find_package fixes (google#7323)

Rename FlatbuffersConfigVersion.cmake to match CMake project name

* CMake find_package fixes (google#7323)

Rename FlatBuffersTargets to match CMake project name
jochenparm pushed a commit to jochenparm/flatbuffers that referenced this issue Oct 29, 2024
@clanghans
(google#7323) Rename CMake files according to project name (google#7378)
61657f3 
* CMake find_package fixes (google#7323)

Rename FlatbuffersConfigVersion.cmake to match CMake project name

* CMake find_package fixes (google#7323)

Rename FlatBuffersTargets to match CMake project name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dbaileychess @clanghans