Replace bash JavaTest.sh with mvn test
#7500
Conversation
nick-someone
force-pushed
the
maven-test
branch
from
d71af57 to
9348391
Compare
|
@paulovap FYI |
nick-someone
force-pushed
the
maven-test
branch
from
0a2677d to
657f3c4
Compare
|
I see it as a positive change and welcome, but I must point out there was a original intent from @aardappel to keep dependencies to a minimum. In this case two dependencies are added (JUnit and Truth for test only). In any case LGTM after my comments are resolved. |
|
I'm OK for adding dependencies to tests, especially if they are automatically resolved. I assume Maven is pretty standard in java development that it isn't a burden for people? Adding dependencies for the runtime is a bit more case-to-case. |
|
I guess dependencies are ok as long as they're only needed by the person making changes to that language's implementation, and like you say, they are pretty standard. The only complication is that it becomes harder to run "all tests" the more stuff you need to have installed for it. |
|
@nick-someone there are few pending comments to address |
nick-someone
force-pushed
the
maven-test
branch
from
657f3c4 to
7ba1495
Compare
nick-someone
force-pushed
the
maven-test
branch
from
3d684a4 to
a751576
Compare
|
@nick-someone Thanks a bunch! |
* Start of mvn-ification of the test * move to right locations * Update the IO done in the test to read from resources / write to temp folders * Add github workflow attempt to mvn test it instead of JavaTest.sh * Pin the Kotlin benchmark's symlink for /java to the right location * Inline equality assertions and format JavaTest.java * fix android gradle source directory Co-authored-by: Derek Bailey <[email protected]>
* Start of mvn-ification of the test * move to right locations * Update the IO done in the test to read from resources / write to temp folders * Add github workflow attempt to mvn test it instead of JavaTest.sh * Pin the Kotlin benchmark's symlink for /java to the right location * Inline equality assertions and format JavaTest.java * fix android gradle source directory Co-authored-by: Derek Bailey <[email protected]>
This moves the pom.xml into
java/, and sets it up as an independently built tool.I symlinked the operative directories that were needed from
tests/, and copied the serialized.monfile so it would be loaded as a test resource.