Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checks for closed/uninitialized context and devices. #93

Merged
merged 1 commit into from
Jan 15, 2021
Merged

Checks for closed/uninitialized context and devices. #93

merged 1 commit into from
Jan 15, 2021

Conversation

zagrodzki
Copy link
Collaborator

Addressess to some extent the weird C++ panic seen in #92 - Close() now has no effect if some devices are still open.

@zagrodzki zagrodzki requested a review from stapelberg January 14, 2021 10:15
@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 79.28% when pulling d7f6d39 on closed-context into c9efe54 on master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 79.28% when pulling d7f6d39 on closed-context into c9efe54 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 79.28% when pulling d7f6d39 on closed-context into c9efe54 on master.

@zagrodzki zagrodzki merged commit 0eba1b1 into master Jan 15, 2021
@zagrodzki zagrodzki deleted the closed-context branch January 15, 2021 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stapelberg stapelberg stapelberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zagrodzki @coveralls @stapelberg