Sandbox brotli

[oshogbo]

This change is 

[cblichmann]

Reviewed 16 of 16 files at r1, all commit messages.
Reviewable status: all files reviewed, 6 unresolved discussions (waiting on @oshogbo)

---

contrib/brotli/sandboxed.h, line 35 at r1 (raw file):

        .AllowSystemMalloc()
        .AllowExit()
        .AllowGetPIDs() // XXX:remove me

What does that mean? Do we need those or not? :)

---

contrib/brotli/utils/utils_brotli_dec.h, line 25 at r1 (raw file):

class BrotliDecoder {
 public:
  BrotliDecoder(BrotliSandbox* sandbox)

Add explicit to constructor

---

contrib/brotli/utils/utils_brotli_dec.h, line 33 at r1 (raw file):

  bool IsInit();

  absl::Status SetParameter(enum BrotliDecoderParameter param, uint32_t value);

No need to specify this in C++, just BrotliDecoderParameter

Code quote:

enum

---

contrib/brotli/utils/utils_brotli_dec.cc, line 76 at r1 (raw file):

  // as function moves to pointer to indicate how much data
  // was compressed.
  // Un this case we compress whole buffer so we don't use it

In

Code quote:

Un

---

contrib/brotli/utils/utils_brotli_enc.h, line 25 at r1 (raw file):

class BrotliEncoder {
 public:
  BrotliEncoder(BrotliSandbox* sandbox)

This constructor also needs to be marked explicit

Code quote:

  BrotliEncoder(BrotliSandbox* sandbox)

---

contrib/brotli/utils/utils_brotli_enc.h, line 33 at r1 (raw file):

  bool IsInit();

  absl::Status SetParameter(enum BrotliEncoderParameter param, uint32_t value);

See above in decoder header.

Code quote:

enum BrotliEncoderParameter param

[oshogbo]

Reviewable status: all files reviewed, 6 unresolved discussions (waiting on @cblichmann)

---

contrib/brotli/sandboxed.h, line 35 at r1 (raw file):

Previously, cblichmann (Christian Blichmann) wrote…

What does that mean? Do we need those or not? :)

Yea I should remove it.

---

contrib/brotli/utils/utils_brotli_dec.h, line 25 at r1 (raw file):

BrotliDecoderParameter
Done.

---

contrib/brotli/utils/utils_brotli_dec.h, line 33 at r1 (raw file):

Previously, cblichmann (Christian Blichmann) wrote…

No need to specify this in C++, just BrotliDecoderParameter

Done.

---

contrib/brotli/utils/utils_brotli_dec.cc, line 76 at r1 (raw file):

Previously, cblichmann (Christian Blichmann) wrote…

In

Thanks!

---

contrib/brotli/utils/utils_brotli_enc.h, line 25 at r1 (raw file):

Previously, cblichmann (Christian Blichmann) wrote…

This constructor also needs to be marked explicit

Done.

---

contrib/brotli/utils/utils_brotli_enc.h, line 33 at r1 (raw file):

Previously, cblichmann (Christian Blichmann) wrote…

See above in decoder header.

Done.

[cblichmann]

Pending internal review.