Use common repository prefix everywhere #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build macros in earlier versions of Bazel (pre-1.0) needed to specify targets in a different format, depending from where they were included/expanded at build time. For example, a `sapi_library()` macro invocation in one of the directories under `examples`, always needed to depend on the SAPI main library as `//sandboxed_api:sapi`. When using SAPI from another Bazel project, the same macro would have needed to depend on `@com_google_sandboxed_api//sandboxed_api:sapi`. The `sapi_library()` macro was thus checking the repository name and conditionally changed the dependencies. This approach is brittle and as of Bazel 3.1.0 no longer works. This CL simple removes the conditional prefix and unconditionally uses `@com_google_sandboxed_api`. Tested on Bazel 1.2.1, 2.2.0 and 3.1.0
happyCoder92
pushed a commit
that referenced
this pull request
May 4, 2022
PiperOrigin-RevId: 311079031 Change-Id: I25b2b9081bd12602853b8b078d715153673c2b8e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build macros in earlier versions of Bazel (pre-1.0) needed to specify
targets in a different format, depending from where they were
included/expanded at build time.
For example, a
sapi_library()macro invocation in one of the directoriesunder
examples, always needed to depend on the SAPI main library as//sandboxed_api:sapi. When using SAPI from another Bazel project, thesame macro would have needed to depend on
@com_google_sandboxed_api//sandboxed_api:sapi. Thesapi_library()macro was thus checking the repository name and conditionally changed
the dependencies. This approach is brittle and as of Bazel 3.1.0 no
longer works.
This CL simple removes the conditional prefix and unconditionally uses
@com_google_sandboxed_api.Tested on Bazel 1.2.1, 2.2.0 and 3.1.0