Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added pkg-config file and .gitignore #55

Closed
wants to merge 2 commits into from

Conversation

oxoocoffee
Copy link

I was trying to build mongo-c-driver 1.7.0 on Mac OS X and it was failing to detect since missing pc file

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@oxoocoffee
Copy link
Author

I signed it!

@@ -0,0 +1,10 @@
prefix=@CMAKE_INSTALL_PREFIX@
exec_prefix=@CMAKE_INSTALL_PREFIX@
libdir=@CMAKE_INSTALL_PREFIX@/lib

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would really use include(GNUInstallDirs) and not hardcode lib.

@cmumford
Copy link
Contributor

@googlebot rescan

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@lavoiesl
Copy link

Any update on this PR?

I’m unable to compile the snappy ruby gem on nix because it can't detect the correct paths. This would be fixed by having a pkg config file.

@pwnall
Copy link
Member

pwnall commented Nov 10, 2019

We will not add pkg-config support for now.

We don't want to get into supporting individual package managers, because the C++ ecosystem hasn't converged into a single solution, and there are quite a few equally reasonable candidates. We can't justify the investment into supporting all the package managers, or into supporting a couple of package managers and trying to rationalize where we drew the line.

@pwnall pwnall closed this Nov 10, 2019
@lovesegfault
Copy link

@pwnall By now pkg-config is a crucial part of the C/++ ecosystem, in particular for developers downstream trying to build bindings or link snappy into their non-C/++ projects.

I ended up on this issue because I need to link snappy into a Rust binary and have to write special code only for snappy because it doesn't provide a pc file.

Given that the complexity cost of this change is very small (24 lines) I ask you to please reconsider this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants