Merge pull request #204 from tstromberg/dupe-tags

Fix missing call to dedup tags after refactor
google · Aug 19, 2020 · 1dd4c54 · 1dd4c54
2 parents da9ed06 + 6148281
commit 1dd4c54
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/pkg/hubbub/issue.go b/pkg/hubbub/issue.go
@@ -24,6 +24,7 @@ import (
 	"github.com/google/go-github/v31/github"
 	"github.com/google/triage-party/pkg/logu"
 	"github.com/google/triage-party/pkg/persist"
+	"github.com/google/triage-party/pkg/tag"
 	"gopkg.in/yaml.v2"
 	"k8s.io/klog/v2"
 )
@@ -204,6 +205,7 @@ func (h *Engine) createIssueSummary(i *github.Issue, cs []*github.IssueComment,
 	}
 	co.ClosedBy = i.GetClosedBy()
 
+	co.Tags = tag.Dedup(co.Tags)
 	sort.Slice(co.Tags, func(i, j int) bool { return co.Tags[i].ID < co.Tags[j].ID })
 	return co
 }

diff --git a/pkg/hubbub/pull_requests.go b/pkg/hubbub/pull_requests.go
@@ -281,6 +281,7 @@ func (h *Engine) createPRSummary(ctx context.Context, pr *github.PullRequest, cs
 		co.Tags = append(co.Tags, tag.Merged)
 	}
 
+	co.Tags = tag.Dedup(co.Tags)
 	sort.Slice(co.Tags, func(i, j int) bool { return co.Tags[i].ID < co.Tags[j].ID })
 	return co
 }