Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transparent generic structs #120

Merged
merged 1 commit into from
Nov 6, 2022

Conversation

djkoloski
Copy link
Member

Fixes #9. Depends on #119 because the generated generic bounds cannot be used in a constant context.

Copy link
Member

@joshlf joshlf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome!! Would you mind rebasing on main now that #119 has merged so that the diff doesn't include those changes as well?

@djkoloski djkoloski force-pushed the transparent_generic_structs branch 2 times, most recently from 0cd1ea0 to 90678f8 Compare November 3, 2022 14:00
Copy link
Member

@joshlf joshlf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more tiny nit, but otherwise lgtm!

@djkoloski djkoloski force-pushed the transparent_generic_structs branch from 90678f8 to 469c916 Compare November 5, 2022 22:37
@djkoloski djkoloski force-pushed the transparent_generic_structs branch 2 times, most recently from dbcb304 to ff9ca67 Compare November 6, 2022 01:16
@djkoloski
Copy link
Member Author

I wanted to incorporate some additional util module cleanup but it seems pretty difficult to have separate PRs that are inter-related on GitHub. I kind of miss gerrit?? I can separate those changes into a separate PR if you'd prefer.

@joshlf
Copy link
Member

joshlf commented Nov 6, 2022

I wanted to incorporate some additional util module cleanup but it seems pretty difficult to have separate PRs that are inter-related on GitHub. I kind of miss gerrit?? I can separate those changes into a separate PR if you'd prefer.

Yeah, I miss gerrit all the time 😞 GitHub's UI is great, but the fact that you can't stack PRs is a travesty. I haven't been doing dev on GH long enough to know the real tricks, but so far my approach has been to just carve off one commit at a time to put through the PR cycle. It's a lot easier for me since I'm self-approving a lot of the more minor changes. I feel like where stacked PRs is a huge deal is when you want to have multiple reviews ongoing at a time.

@joshlf
Copy link
Member

joshlf commented Nov 6, 2022

Oh but to respond to your comment about this PR: I saw, and those changes look great! I'm happy to just keep them in this PR and we can figure out a better workflow later if it keeps being a problem.

@djkoloski djkoloski force-pushed the transparent_generic_structs branch 3 times, most recently from eb307a5 to 30acdfe Compare November 6, 2022 01:40
Also consolidates some utility types and macros.
@djkoloski
Copy link
Member Author

Got some friction with CI, #69 would help improve the contribution experience.

@joshlf joshlf merged commit a728cb9 into google:main Nov 6, 2022
joshlf pushed a commit that referenced this pull request Aug 3, 2023
Also consolidate some utility types and macros.

Closes #9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support generic parameters when deriving AsBytes on a #[repr(transparent)] type
2 participants