Update MSRV to 1.65.0 #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshlf
force-pushed
the
msrv
branch
6 times, most recently
from
5f95320 to
6aef126
Compare
|
Looks like the tests are failing due to rust-lang/miri#2791. |
Also update the versions of the stable and nightly compiler toolchains that are pinned in CI.
joshlf
added a commit
that referenced
this pull request
Aug 8, 2023
It turned out that there were only a few lines of code that required our MSRV to be as high as it was before this commit (1.65.0), and those lines were easy to modify to be compatible with this new MSRV. Note that this requires re-introducing a bug that was removed in #156 because the bug is based on an underlying bug in the standard library. That bug was considered minor at the time it was discovered, and I still consider it minor now. See #64 for more details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also update the versions of the stable and nightly compiler toolchains that are pinned in CI.