[derive] Simplify code, remove obsolete features #373
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got too fancy with my GitHub-as-Gerrit foo and GitHub closed the old PR, so I'm reopening it here.
Clean up the implementation, especially in
fn impl_block
. Make the following notable changes:syn
didn't support parsing macro invocations in const generics without thefull
feature enabled. To avoid the compile-time overhead of that feature, we worked around it by constructing AST nodes manually.syn
has since added support for this without requiring thefull
feature, so we make use of it.[T; 2]
) and those that didn't (like[u8; 2]
). We made a change in Move field type bounds into where clauses #119 that made this distinction irrelevant, but we never removed the code to perform the split. In this commit, we remove that code. That code was the only reason we needed to enablesyn
'svisit
feature, so we are also able to remove that feature dependency.