fix: issues in Options classes (#528)

googleapis · Feb 14, 2024 · aa9ba3a · aa9ba3a
1 parent 7d2533e
commit aa9ba3a
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/src/Options/ClientOptions.php b/src/Options/ClientOptions.php
@@ -173,7 +173,7 @@ private function fromArray(array $arr): void
         $this->setTransport($arr['transport'] ?? null);
         $this->setTransportConfig(new TransportOptions($arr['transportConfig'] ?? []));
         $this->setVersionFile($arr['versionFile'] ?? null);
-        $this->setDescriptorsConfigPath($arr['descriptorsConfigPath']);
+        $this->setDescriptorsConfigPath($arr['descriptorsConfigPath'] ?? null);
         $this->setServiceName($arr['serviceName'] ?? null);
         $this->setLibName($arr['libName'] ?? null);
         $this->setLibVersion($arr['libVersion'] ?? null);
@@ -302,7 +302,7 @@ public function setGapicVersion(?string $gapicVersion): void
     public function setClientCertSource(?callable $clientCertSource)
     {
         if (!is_null($clientCertSource)) {
-            $this->clientCertSource = Closure::fromCallable($clientCertSource);
+            $clientCertSource = Closure::fromCallable($clientCertSource);
         }
         $this->clientCertSource = $clientCertSource;
     }

diff --git a/src/Options/TransportOptions/GrpcFallbackTransportOptions.php b/src/Options/TransportOptions/GrpcFallbackTransportOptions.php
@@ -77,7 +77,7 @@ private function fromArray(array $arr): void
     public function setHttpHandler(?callable $httpHandler)
     {
         if (!is_null($httpHandler)) {
-            $this->httpHandler = Closure::fromCallable($httpHandler);
+            $httpHandler = Closure::fromCallable($httpHandler);
         }
         $this->httpHandler = $httpHandler;
     }
@@ -88,7 +88,7 @@ public function setHttpHandler(?callable $httpHandler)
     public function setClientCertSource(?callable $clientCertSource)
     {
         if (!is_null($clientCertSource)) {
-            $this->clientCertSource = Closure::fromCallable($clientCertSource);
+            $clientCertSource = Closure::fromCallable($clientCertSource);
         }
         $this->clientCertSource = $clientCertSource;
     }

diff --git a/src/Options/TransportOptions/GrpcTransportOptions.php b/src/Options/TransportOptions/GrpcTransportOptions.php
@@ -124,7 +124,7 @@ public function setInterceptors(array $interceptors)
     public function setClientCertSource(?callable $clientCertSource)
     {
         if (!is_null($clientCertSource)) {
-            $this->clientCertSource = Closure::fromCallable($clientCertSource);
+            $clientCertSource = Closure::fromCallable($clientCertSource);
         }
         $this->clientCertSource = $clientCertSource;
     }

diff --git a/src/Options/TransportOptions/RestTransportOptions.php b/src/Options/TransportOptions/RestTransportOptions.php
@@ -85,7 +85,7 @@ private function fromArray(array $arr): void
     public function setHttpHandler(?callable $httpHandler)
     {
         if (!is_null($httpHandler)) {
-            $this->httpHandler = Closure::fromCallable($httpHandler);
+            $httpHandler = Closure::fromCallable($httpHandler);
         }
         $this->httpHandler = $httpHandler;
     }
@@ -96,7 +96,7 @@ public function setHttpHandler(?callable $httpHandler)
     public function setClientCertSource(?callable $clientCertSource)
     {
         if (!is_null($clientCertSource)) {
-            $this->clientCertSource = Closure::fromCallable($clientCertSource);
+            $clientCertSource = Closure::fromCallable($clientCertSource);
         }
         $this->clientCertSource = $clientCertSource;
     }