Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: drop support for PHP 5.6 #397

Merged
merged 9 commits into from
Aug 10, 2022
Merged

feat: drop support for PHP 5.6 #397

merged 9 commits into from
Aug 10, 2022

Conversation

bshaffer
Copy link
Contributor

@bshaffer bshaffer commented Jul 26, 2022 •
edited
Loading

  • Primitive type-hints aren't supported in PHP 5.x, so we'll need to drop that version before we can use them.
  • google/protobuf now has a minimum of PHP 7.0, and we require some of the changes in this library.

See #403

@bshaffer bshaffer requested review from a team as code owners July 26, 2022 16:44
@bshaffer bshaffer mentioned this pull request Jul 26, 2022
Closed
@bshaffer bshaffer requested a review from dwsupplee July 26, 2022 23:45
This was referenced Aug 2, 2022
Merged
Merged
@bshaffer bshaffer mentioned this pull request Aug 10, 2022
Merged
@bshaffer bshaffer changed the title chore: drop support for PHP 5.6 feat: drop support for PHP 5.6 Aug 10, 2022
@bshaffer bshaffer merged commit b888b24 into main Aug 10, 2022
@bshaffer bshaffer deleted the drop-php56 branch August 10, 2022 17:42
@release-please release-please bot mentioned this pull request Aug 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwsupplee dwsupplee dwsupplee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bshaffer @dwsupplee