feat: add ResourceHelperTrait #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bshaffer
reviewed
Nov 14, 2022
|
I just set aside a block of time for tomorrow morning to review. |
bshaffer
requested changes
Nov 18, 2022
|
Sorry about the delay, I was out the last few days. Taking a look today. |
dwsupplee
suggested changes
Nov 21, 2022
There was a problem hiding this comment.
Looks very clean and straightforward, just a few thoughts. Nice work @noahdietz.
Co-authored-by: David Supplee <[email protected]>
Co-authored-by: David Supplee <[email protected]>
dwsupplee
approved these changes
Dec 5, 2022
bshaffer
approved these changes
Dec 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a new
ResourceHelperTraitthat supplies functionality for loading a resource name template map from a descriptor config, retrieving aPathTemplate, and parsing values using registered templates. This can be used by GAPIC clients to replace much of the resource template properties generated into every client.Proposal is at http://go/php-resource-name-refactor.