Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup(storage): remove testbench hack for XML #5097

Merged
merged 1 commit into from
Sep 19, 2020
Merged

cleanup(storage): remove testbench hack for XML #5097

merged 1 commit into from
Sep 19, 2020

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Sep 19, 2020 •
edited
Loading

Cleanup the library and the testbench to use the same paths for the XML
API on the testbench as we use in production. Wrote a test to verify the
testbench can be used via ClientOptions::set_endpoint().

Part of the work for #5072

This change is Reviewable

@coryan
cleanup(storage): remove testbench hack for XML
8ddce0a 
Cleanup the library and the testbench to use the same paths for the XML
API on the testbench as we use in production. Wrote a test to verify the
testbench can be used via `ClientOptions::set_endpoint()`.
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 19, 2020
@codecov
Copy link

codecov bot commented Sep 19, 2020

Codecov Report

Merging #5097 into master will decrease coverage by 0.00%.
The diff coverage is 94.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5097      +/-   ##
==========================================
- Coverage   95.82%   95.82%   -0.01%     
==========================================
  Files         986      986              
  Lines       90282    90350      +68     
==========================================
+ Hits        86516    86577      +61     
- Misses       3766     3773       +7
Impacted Files Coverage Δ
...torage/tests/object_basic_crud_integration_test.cc 90.37% <94.11%> (+3.80%) ⬆️
google/cloud/storage/client_options.cc 97.59% <100.00%> (ø)
google/cloud/storage/client_options_test.cc 100.00% <100.00%> (ø)
...bigtable/examples/bigtable_hello_instance_admin.cc 82.02% <0.00%> (-2.25%) ⬇️
.../cloud/storage/benchmarks/throughput_experiment.cc 78.46% <0.00%> (-0.52%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abc8e9c...8ddce0a. Read the comment docs.

@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Sep 19, 2020
@coryan coryan marked this pull request as ready for review September 19, 2020 12:38
@coryan coryan requested a review from a team as a code owner September 19, 2020 12:38
@coryan coryan merged commit 3182f8d into googleapis:master Sep 19, 2020
@coryan coryan deleted the fix-storage-set-endpoint-with-emulator branch September 19, 2020 15:27
@vnghia vnghia mentioned this pull request Dec 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devbww devbww devbww approved these changes

Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coryan @devbww