chore: fix type errors in build (#2577)

* chore: fix type errors in build

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* fix docs links

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

.repo-metadata.json

@@ -2,7 +2,7 @@
   "name": "storage",
   "name_pretty": "Google Cloud Storage",
   "product_documentation": "https://cloud.google.com/storage",
-  "client_documentation": "https://googleapis.dev/nodejs/storage/latest",
+  "client_documentation": "https://cloud.google.com/nodejs/docs/reference/storage/latest",
   "issue_tracker": "https://issuetracker.google.com/savedsearches/559782",
   "release_level": "stable",
   "language": "nodejs",

src/crc32c.ts

@@ -257,10 +257,16 @@ class CRC32C implements CRC32CValidator {
   static async fromFile(file: PathLike) {
     const crc32c = new CRC32C();
 
-    await new Promise((resolve, reject) => {
+    await new Promise<void>((resolve, reject) => {
       createReadStream(file)
-        .on('data', (d: Buffer) => crc32c.update(d))
-        .on('end', resolve)
+        .on('data', (d: string | Buffer) => {
+          if (typeof d === 'string') {
+            crc32c.update(Buffer.from(d));
+          } else {
+            crc32c.update(d);
+          }
+        })
+        .on('end', () => resolve())
         .on('error', reject);
     });
 

src/file.ts

@@ -2310,8 +2310,12 @@ class File extends ServiceObject<File, FileMetadata> {
           writable.write(data);
           fileStream
             .pipe(writable)
-            .on('error', callback)
-            .on('finish', callback);
+            .on('error', (err: Error) => {
+              callback(err, Buffer.from(''));
+            })
+            .on('finish', () => {
+              callback(null, data);
+            });
         })
         .on('end', () => {
           // In the case of an empty file no data will be received before the end event fires

system-test/storage.ts

@@ -2566,7 +2566,7 @@ describe('storage', function () {
 
       const file = bucket.file(filename);
 
-      await new Promise((resolve, reject) => {
+      await new Promise<void>((resolve, reject) => {
         file
           .createReadStream()
           .on('error', reject)
@@ -2578,7 +2578,7 @@ describe('storage', function () {
           })
           .pipe(fs.createWriteStream(tmpFilePath))
           .on('error', reject)
-          .on('finish', resolve);
+          .on('finish', () => resolve());
       });
 
       await file.delete();