Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add types to package.json exports #45

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

chrispawley
Copy link

Using this package with the latest default angular tsconfig, which uses 'moduleResolution: bundler' i got this typescript error:

Could not find a declaration file for module '@googlemaps/adv-markers-utils'
There are types at '@googlemaps/adv-markers-utils/dist/index.d.ts', but this result could not be resolved when respecting package.json "exports".

Updating package.json imports format resolved this issue.

from:

"import": "./dist/index.modern.js,"

to:

"import": { "types": "./dist/index.d.ts", "default": "./dist/index.modern.js" }

🦕

Copy link

google-cla bot commented Feb 17, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@chrispawley chrispawley force-pushed the addTypesToPackageExports branch from 8f9cfe2 to e66536e Compare February 17, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant