chore: upgrade Gosling #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etowahadams
commented
Jun 5, 2024
Comment on lines
+85
to
+89
| // FIXME: This is a workaround to fix the zoomTo issue | ||
| // The zoomTo function is not working properly when it is called immediately. | ||
| setTimeout(() => { | ||
| gosRef.current?.api.zoomTo(viewId, position, padding, duration) | ||
| }, 150) |
There was a problem hiding this comment.
Where I added a setTimout to get around the zoom problem.
wangqianwen0418
approved these changes
Jun 6, 2024
| setTimeout(() => { | ||
| if (gosRef.current && gosAPI) { | ||
| const { viewId, action, duration } = gosAPI | ||
| const viewIds = gosRef.current.api.getTrackIds() |
There was a problem hiding this comment.
Are we changing the api from view ids to track ids? If yes, would it be better to just name the variables as trackIds?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades
Refactor Streamlit component to use the current Gosling API. This involved implementing several workarounds.
Screen.Recording.2024-06-05.at.6.12.17.PM.mov
Details
Naively updating Gosling/HiGlass/Pixi caused this PIXI-related export issue: pixijs/pixijs#8554
I discovered that the old
react-scriptsused a version of Webpack that was the source of the problem. I upgradedreact-scriptswhich also required other dependencies to be upgraded. Eventually,npm run buildworked properly.I tested it with https://github.com/wangqianwen0418/streamlit-gosling-demo and found that the zoomTo functionalities were now broken. So I put the Gosling component in a useMemo. This solved the problems except that the first time zoomTo was used it would never work, it would just zoom out all the way. So I had to get creative with the setTimeouts.
I think the problem is something with the way the streamlit component is configured. This would be something to look into in a future PR, but everything seems to be working for now.