Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slope explosion on long Slurs #90

Closed
arshiacont opened this issue Aug 28, 2019 · 2 comments
Closed

Slope explosion on long Slurs #90

arshiacont opened this issue Aug 28, 2019 · 2 comments

Comments

@arshiacont
Copy link

Unit test:

{[ 
   (* meas. 44 *)  \key<-3> \slurBegin:1<curve="up"> \beamBegin:1 e&3/8. d/16 c/8 \beamEnd:1 \beamBegin:1 b&2/8. a&/16 g/8 \beamEnd:1 \bar 
   (* meas. 45 *)  \beamBegin:1 f/8. g/16 e/8 \beamEnd:1 \beamBegin:1 f/8. d&/16 d/8 \beamEnd:1 \bar 
   (* meas. 46 *)  \beamBegin:1 e&/8. f/16 d/8 \beamEnd:1 \beamBegin:1 e&/8. c&/16 d&/8 \beamEnd:1 \bar 
   (* meas. 47 *)  e&/4. b&1/8 \slurEnd:1 _/8 _/8 \bar 
   (* meas. 48 *)  _*3/4 \bar 
 ]
  }

This is a sample. We so this problem alot.

The slur height is too big and when put in a real score, this pattern persists and goes beyond its system bounding box as seen here:
image
dfober added a commit that referenced this issue Aug 30, 2019
@dfober
partial fix for issue #90
d445883 
actually slurs need to be redesigned
@dfober
Copy link
Member

dfober commented Aug 30, 2019

a partial fix has been pushed to git
actually slurs need to be redesigned (which requires more time)

@dfober
Copy link
Member

dfober commented Feb 25, 2020

I think I can close this one now.

@dfober dfober closed this as completed Feb 25, 2020
arshiacont added a commit to Antescofo/guidolib that referenced this issue Feb 22, 2022
@arshiacont
Merge commit '0351c44b4419fbfe327c160707f3aafbc75c3229' into feature/…
3fe809a 
…GUID-135-bowing

* commit '0351c44b4419fbfe327c160707f3aafbc75c3229': (81 commits)
  examples, issues and regression test added
  support for bowing
  unused code (or useless lines) removed
  musical symbol handled at AR level
  ARBow implementation (in progress)
  ARMarcato inherits now from ARArticulation, redundant code has been removed
  useless code removed
  changelog update
  documentation
  new \bow tag in progress
  change log
  partial fix for issue grame-cncm#90 actually slurs need to be redesigned
  test version increased
  unused variable commented
  comment useless (and maybe incorrect) guido warning
  warning changed: todo -> TODO
  fix svg export issue with '&' character
  move version num to 1.6.8.0
  add webfont check to makefile
  add guido web font to npm
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dfober @arshiacont