-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(grafast/grafserv/src/servers/deno.ts): add deno server #500
Conversation
(Just a note to say thank you for submitting this. I'm currently super busy preparing for GraphQLConf so I might not get around to properly evaluating this until October - not least because I've not really used Deno before and will have to familiarize myself with it before taking on the maintenance of this adaptor.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great; I love how simple it is!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's as much as I can do right now; please:
- Solve the issue so that TypeScript running on Node doesn't crash (install the Deno types?)
- Add a page to the Grafast documentation like this one: https://github.com/benjie/crystal/blob/main/grafast/website/grafserv/servers/fastify.md (Ideally better!)
Thanks for your review ! I will add the required changes you mention asap. Thanks for your work. |
(Please be aware this PR should now be raised against https://github.com/graphile/crystal instead ❤️) |
Please re-open this against the above repo. I've pushed a few more commits but I've literally no idea how to go about running this locally - it seems that Deno doesn't support running local code in |
Noted ! Thanks for your work @benjie |
Incidentally if you need help doing the git-fu to move this over:
Then raise a PR :) |
A first stop to be used in Deno.