Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(grafast/grafserv/src/servers/deno.ts): add deno server #500

Closed
wants to merge 7 commits into from

Conversation

nestarz
Copy link

@nestarz nestarz commented Sep 6, 2023

A first stop to be used in Deno.

@benjie
Copy link
Member

benjie commented Sep 11, 2023

(Just a note to say thank you for submitting this. I'm currently super busy preparing for GraphQLConf so I might not get around to properly evaluating this until October - not least because I've not really used Deno before and will have to familiarize myself with it before taking on the maintenance of this adaptor.)

Copy link
Member

@benjie benjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great; I love how simple it is!

Copy link
Member

@benjie benjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's as much as I can do right now; please:

  1. Solve the issue so that TypeScript running on Node doesn't crash (install the Deno types?)
  2. Add a page to the Grafast documentation like this one: https://github.com/benjie/crystal/blob/main/grafast/website/grafserv/servers/fastify.md (Ideally better!)

@nestarz
Copy link
Author

nestarz commented Sep 16, 2023

Thanks for your review ! I will add the required changes you mention asap. Thanks for your work.

@benjie
Copy link
Member

benjie commented Oct 3, 2023

(Please be aware this PR should now be raised against https://github.com/graphile/crystal instead ❤️)

@benjie
Copy link
Member

benjie commented Oct 3, 2023

Please re-open this against the above repo. I've pushed a few more commits but I've literally no idea how to go about running this locally - it seems that Deno doesn't support running local code in npm compatibility mode? denoland/deno#18474 Without that, I can't be certain it works, so that's the first thing to solve.

@benjie benjie closed this Oct 3, 2023
@nestarz
Copy link
Author

nestarz commented Oct 3, 2023

Noted ! Thanks for your work @benjie

@benjie
Copy link
Member

benjie commented Oct 3, 2023

Incidentally if you need help doing the git-fu to move this over:

  1. Pull down these commits into your local clone (git pull --rebase)
  2. Fork the graphile/crystal repo via GitHub interface
  3. Change the remote for your existing local clone to point at the new repository (git remote set-url origin [email protected]:nestarz/<new repo name here>.git)
  4. git push -u origin patch-1

Then raise a PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants