Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

store: Fix fulltextsearch space handling #3048

Merged
merged 1 commit into from
Dec 16, 2021
Merged

store: Fix fulltextsearch space handling #3048

merged 1 commit into from
Dec 16, 2021

Conversation

mangas
Copy link
Contributor

@mangas mangas commented Dec 9, 2021 •
edited by Jannis
Loading

Fixes #3043

@mangas mangas force-pushed the filipe/fulltextsearch branch from ba25b8c to 7335a28 Compare December 10, 2021 14:55
@mangas mangas requested a review from lutter December 10, 2021 14:58
@mangas mangas force-pushed the filipe/fulltextsearch branch 4 times, most recently from 5d2d6c2 to d4a6d65 Compare December 12, 2021 22:01
Jannis
Jannis requested changes Dec 15, 2021
View reviewed changes
@mangas mangas force-pushed the filipe/fulltextsearch branch 2 times, most recently from b5c48af to 05fb61a Compare December 15, 2021 20:02
@mangas mangas marked this pull request as ready for review December 15, 2021 20:09
@mangas mangas requested review from Jannis, lutter and leoyvens December 15, 2021 20:09
Jannis
Jannis approved these changes Dec 16, 2021
View reviewed changes
Copy link
Contributor

@Jannis Jannis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mangas mangas force-pushed the filipe/fulltextsearch branch from 05fb61a to ff236aa Compare December 16, 2021 10:49
@mangas mangas requested a review from Jannis December 16, 2021 10:49
leoyvens
leoyvens approved these changes Dec 16, 2021
View reviewed changes
Copy link
Collaborator

@leoyvens leoyvens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't know you could have an expected message in should_panic, nice!

@mangas mangas merged commit f2ea6b9 into master Dec 16, 2021
@mangas mangas deleted the filipe/fulltextsearch branch December 16, 2021 16:02
kamilkisiela pushed a commit that referenced this pull request Jan 5, 2022
@mangas @kamilkisiela
store: Fix fulltextsearch space handling (#3048)
3ff6fc6
kamilkisiela pushed a commit that referenced this pull request Jan 12, 2022
@mangas @kamilkisiela
store: Fix fulltextsearch space handling (#3048)
b49c758
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jannis Jannis Jannis approved these changes

@leoyvens leoyvens leoyvens approved these changes

@lutter lutter Awaiting requested review from lutter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fulltext search queries with spaces (but no operators) fail badly
4 participants
@mangas @Jannis @lutter @leoyvens