This repository has been archived by the owner on Feb 8, 2018. It is now read-only.
Squish another #1369 regression #2079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,6 +1,6 @@ | |||
| """Show information about a single participant. It might be you! | |||
| """ | |||
| from gittip.utils import get_participant | |||
| from gittip.utils import get_participant, get_avatar_url | |||
There was a problem hiding this comment.
This file doesn't seem to use get_avatar_url...?
There was a problem hiding this comment.
@seanlinsley It's used in an included template.
There was a problem hiding this comment.
Shouldn't the template itself load it then? Or are templates not able to do that on their own?
There was a problem hiding this comment.
I don't think templates can import python functions.
There was a problem hiding this comment.
Yeah, that appears to be the case. Either way, this fixes the problem.
seanlinsley
added a commit
that referenced
this pull request
Feb 27, 2014
Squish another #1369 regression
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.