This repository has been archived by the owner on Feb 8, 2018. It is now read-only.
Correct customer URL to Balanced #2222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clone1018
added a commit
that referenced
this pull request
Apr 2, 2014
Correct customer URL to Balanced
|
Thanks for the fix Bruce, this bothered me too. |
| @@ -76,7 +76,7 @@ | |||
| <div class="account-type"> | |||
| Balanced Payments | |||
| {% if user.ADMIN and participant.balanced_customer_href %} | |||
| (<a href="https://dashboard.balancedpayments.com/#/{{ participant.balanced_customer_href[4:] }}" | |||
| (<a href="https://dashboard.balancedpayments.com/#/marketplaces/MP12Xw5lL6iaILtqImIoroDL{{ participant.balanced_customer_href }}" | |||
There was a problem hiding this comment.
I've been considering our marketplace ID to be secret.
There was a problem hiding this comment.
I'm told it's not dangerous to share. IRC
I'm still not comfortable sharing it, tbh. Feels like something that could be used in social engineering.
There was a problem hiding this comment.
Looks like we can't change the ID through the dashboard. We could ask Balanced to change it for us, probably, but since they're saying it's safe, I guess I'll drop it.
|
The ticket for this is #2085. Not sure if this PR really solves the problem or just works around it, possibly only in some cases. I believe we have two kinds of balanced URI stored in our db. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Gittip provided URL to Balanced makes no sense. This is an attempt to fix it. I haven't ever tried testing with Balanced, so I do not know how to test this change. But, I know that the existing code does not work. This really cannot be any worse.