-
Notifications
You must be signed in to change notification settings - Fork 309
Conversation
I'm skunked by AspenWeb/pando.py#462 for now. :-( |
efec253
to
072a503
Compare
Down to one test failure. I'm using an unreleased version of Aspen locally that includes AspenWeb/pando.py#463. I'm waiting to cut a new Aspen release until we're sure we've got a version that's going to work with Gratipay. |
I also want to double-check the interaction of |
Here's the diff of the output from master and this branch for the failing test: --- good.txt 2015-07-01 07:31:09.000000000 -0400
+++ bad.txt 2015-07-01 07:43:17.000000000 -0400
@@ -186,8 +186,8 @@
<p>To receive money, do something awesome and then tell people about it:</p>
<ol>
- <li><a href='/alice/'>Fill out your profile</a> to let others know about you.</li>
- <li>Reach a wider audience by <a href='/alice/widgets'>embedding our widgets</a> on your blog/website.</li>
+ <li><a href='/alice/'>Fill out your profile</a> to let others know about you.</li>
+ <li>Reach a wider audience by <a href='/alice/widgets'>embedding our widgets</a> on your blog/website.</li>
</ol>
</div> |
In other words, we're escaping HTML when we don't want to. |
I believe this has something to do with our i18n plumbing relative to the scoping changes in simplates (see AspenWeb/pando.py#462, etc.). |
Hypothesis: the htmlescape function is never making it into the simplate rendering context, because it's being placed in the state dict, which no longer influences rendering context as of AspenWeb/pando.py#463. Therefore, the return value of get_text is a string and not a |
Yeah, it's because the |
I guess we need a new way to influence template context from algorithm functions. Maybe an explicit |
Looking at this now ... |
Need to place htmlescape in the right dict now that we've separated render context from state. h/t @Changaco in AspenWeb/pando.py#469
bba1051
to
1c9d542
Compare
Rebased on master to pick up #3581. |
84db06a
to
fca0cf1
Compare
Ready for review. |
Ping @rohitpaulk @rorepo @kzisme @techtonik et al. I'd like to get this out the door today, because it addresses security issues (we really should've done this in https://github.com/gratipay/security-qf35us before making that public :-( ). |
Proceeding since it's security-related. |
0.39 has the changes we're interested in. Here's the Changelog:
https://github.com/gratipay/aspen-python/blob/master/Changelog.md#040---released-mon-jun-29-2015-by-whit537