Handle = in synonymous variant names
#111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahwagner
approved these changes
Feb 5, 2021
|
hgvs expressions are being encoded so they don't have this problem but we can switch to this implementation to make them look "nicer". |
|
Okay. I'm fine with it either way–if you are happy with the current solution, I think it is good to merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CIViCpy check VCF fields for containing
=and fails when such a variant is encountered because having a field value contain this character would break VCF specs since=has a special meaning for parsing. However, synonymous variants will legitimately contain this characters in their name (e.g.E55= (c.165G>A)). This PR implements a solution for this problem by replacing the=in the variant with the wildtype amino acid(s).Closes #110.