-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make official v2 release + gh action for docker image #131
Conversation
Added work for creating docker images. I didn't pin a version in the Dockerfile. Wasn't sure the best way to handle this. I can revert back to manually changing or think of an alternate way without having to change the version in 2 places. I think we'll also want to set the dockerhub secrets in the repo to use the griffithlab user or a different user? |
I think this is fine although we should monitor this in practice. Sometimes pypi's registry gets backed up and even though a new release is live, pip isn't aware of the new version so an old version would get installed/released in the Docker image.
That is a good question. I haven't set up a github action for this before so I'm not entirely sure. Let me ask some of my colleagues who might have more info. |
Will install civicpy version based on GH release tag that was published
RUN --mount=type=secret,id=civicpy_version \ | ||
civicpy_version="$(cat /run/secrets/civicpy_version)" \ | ||
&& pip install civicpy==${civicpy_version} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@susannasiebert Added these lines to install specific version based on the GH release tag. Exposing GH actions env var to Dockerfile was tricky. This was one solution that worked. If you know of an alternate way, we can do that.
@susannasiebert I can see if there's a way to check that the version exists before starting docker build action. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
@acoffman and @susannasiebert agreed that we should just make the official v2 release and release molecular profiles separately
Note: This assumes the GH release tag does not include the
v
prefix. For instance, use1.0.0
rather thanv1.0.1