Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stay compatible with pandas >=2.0 #140

Merged

Conversation

dameyerdave
Copy link
Contributor

I had a problem running search_variants_by_coordinates from civicpy. After a bit of research I could figure out what the problem is:
Because of some implementation changes in pandas version >=2.0 a index series can no longer be intersected using the & operator, but a set can. I found the valuable hint to this problem here https://linuxhint.com/panda-series-intersection/.

I hope you find this useful and you would merge this pull request.

Copy link
Collaborator

@susannasiebert susannasiebert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@susannasiebert susannasiebert merged commit db39767 into griffithlab:master Apr 18, 2024
@susannasiebert
Copy link
Collaborator

@dameyerdave Thank you for this fix. We just released version 3.1.0, which includes this update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants