Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use '*' as a wildcard for coordinate exact searches #84

Merged
merged 2 commits into from
May 18, 2020

Conversation

susannasiebert
Copy link
Collaborator

Some variants will have None reference or alternate bases (e.g., indels). Previously, a None in the coordinate query would match any reference or alternate base (i.e., act as a de-facto wildcard).

This PR changes this behavior so that using None in your query for your reference and/or alternate base will only match variants with no reference and/or alternate base. A new wildcard character * is introduced which can be used in the coordinate query for reference or alternate alleles and match any reference alleles or alternate alleles (including variants without reference or alternate alleles).

@susannasiebert susannasiebert requested a review from ahwagner May 14, 2020 15:41
Copy link
Member

@ahwagner ahwagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work.

@susannasiebert susannasiebert merged commit 144dcb9 into master May 18, 2020
@susannasiebert susannasiebert deleted the search_wildcard branch May 19, 2020 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants