New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the project root management #12

Merged

Flegyas merged 2 commits into develop from feature/autoroot

Jan 7, 2022

Member

lucmos commented Jan 6, 2022 •

edited by Flegyas

Loading

This PR:

Removes the PROJECT_ROOT environment variable, which was a pain to configure each time
Infers the PROJECT_ROOT from the git repository, if it is not a git repository it fallbacks to the current working directory
Changes the behaviour to not change the cwd to the project root

On hold until Refactor codebase to be compliant to the pre-commits #11 is merged
Rebase onto develop

lucmos requested a review from Flegyas

January 6, 2022 17:58


          Remove the PROJECT_ROOT env variable and infer it

4ac051a

Flegyas force-pushed the feature/autoroot branch from 95cbeee to 4ac051a Compare

January 7, 2022 22:28


          Very important change :D

d9082be

Flegyas merged commit 9c21467 into develop

Flegyas deleted the feature/autoroot branch

January 7, 2022 22:33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet