Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protoc_gen_swagger should use target_name.swagger.json as out #640

Closed
achew22 opened this issue May 3, 2018 · 7 comments
Closed

protoc_gen_swagger should use target_name.swagger.json as out #640

achew22 opened this issue May 3, 2018 · 7 comments

Comments

@achew22
Copy link
Collaborator

achew22 commented May 3, 2018

By default protoc_gen_swagger should use target_name.swagger.json as the output file and use something like #591 to generate a single file output of that name.

@cy-zheng
Copy link
Contributor

cy-zheng commented May 4, 2018

It's an important feature. I can't find a third-party tool to solve this unless parsing swagger.json files by myself.

@achew22
Copy link
Collaborator Author

achew22 commented May 4, 2018

@cy-zheng would you like to pick up where #591 left off? It wouldn't be too much more work to enhance with a test then I'll merge it and do the Bazel change. What do you think?

@cy-zheng
Copy link
Contributor

cy-zheng commented May 4, 2018

Well, I'll take a look at it this weekend. It seems make it work by just adding some test cases.

@achew22
Copy link
Collaborator Author

achew22 commented May 4, 2018

Yep, that's exactly what we need to get it submitted 😄

@cy-zheng
Copy link
Contributor

cy-zheng commented May 5, 2018

#643

@cy-zheng
Copy link
Contributor

Combine separate swagger file to one in #643
the cmd like this:
protoc src/pb/proto/models.proto src/pb/proto/models2.proto --swagger_out=allow_merge=true,merge_file_name=myswagger,logtostderr=true:src/static/

ithinker1991 pushed a commit to tronprotocol/grpc-gateway that referenced this issue Jun 18, 2018
@tmc tmc added openapi and removed openapi labels Jun 19, 2018
@stale
Copy link

stale bot commented Sep 9, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Sep 9, 2019
@stale stale bot closed this as completed Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants