Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pr issue template v2 #1367

Closed
wants to merge 3 commits into from
Closed

Pr issue template v2 #1367

wants to merge 3 commits into from

Conversation

iamrajiv
Copy link
Contributor

References to other Issues or PRs

#1366

removed Issue template from _docs and made issue and PR template in .github of v2 branch of grpc-gateway

Have you read the Contributing Guidelines?

Yes

Brief description of what is fixed or changed

Other comments

@johanbrandhorst
Copy link
Collaborator

I think you need to rebase on v2

@iamrajiv
Copy link
Contributor Author

hey @johanbrandhorst can you help me why one test is not passing?

@johanbrandhorst
Copy link
Collaborator

hey @johanbrandhorst can you help me why one test is not passing?

I'm pretty sure it's because you need to rebase your branch on top of v2:

$ git pull --rebase origin v2

Should do it.

@iamrajiv
Copy link
Contributor Author

@johanbrandhorst I am closing this PR because of conflict. I have made a new PR #1371

@iamrajiv iamrajiv closed this May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanbrandhorst johanbrandhorst johanbrandhorst approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iamrajiv @johanbrandhorst @googlebot