Remove indirect github.com/golang/glog dependency of runtime package #1694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonewang
changed the title
johanbrandhorst
approved these changes
Sep 25, 2020
|
Thanks for your contribution! |
|
Could you please cherry pick this against master? |
This dependency as far as I can tell doesn't exist in master because httprule/parse.go is only used in protoc-gen-grpc-gateway which isn't imported by any user code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References to other Issues or PRs
Similar intended fix as #118
Have you read the Contributing Guidelines?
Yep
Brief description of what is fixed or changed
Remove glog in dependency of runtime package so projects that have forked
glogcan use grpc-gateway without a flag collision.#1449 introduced the httprule import to mux.go which causes
glogto be imported when runtime is imported.Other comments
There are other glog imports in internal/, protoc-gen-grpc-gateway/, and protoc-gen-openapiv2/ that don't seem to cause flag collisions when creating a mux and using the generated .pb.gw.go files. I can remove or update those to use grpclog instead if desired.